Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 2, 2020

This PR does the following:

  • Moves the regen-pegen target to the end of the regen-all so the changes in regen-token and are correctly picked up.
  • Adds a new target regen-pegen-metaparser that regenerates the metaparser (this means also that the CI will check that this file is updated from now on)
  • Adds regen-pegen-metaparser to regen-all

https://bugs.python.org/issue40334

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What brought about the desire to automatically regenerate the meta-parser?

@pablogsal
Copy link
Member Author

What brought about the desire to automatically regenerate the meta-parser?

Consistency with how we handle the rest of autogenerated files to know that they are up to date, more than anything.

@gvanrossum
Copy link
Member

gvanrossum commented May 2, 2020 via email

@pablogsal pablogsal merged commit d2baff4 into python:master May 2, 2020
@pablogsal pablogsal deleted the bpo-40334-regen-metagrammar branch May 2, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants