[3.9] bpo-40334: Produce better error messages for non-parenthesized genexps (GH-20153) #20307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonGH-20153) The error message, generated for a non-parenthesized generator expression in function calls, was still the generic `invalid syntax`, when the generator expression wasn't appearing as the first argument in the call. With this patch, even on input like `f(a, b, c for c in d, e)`, the correct error message gets produced. (cherry picked from commit ae14583) Co-authored-by: Lysandros Nikolaou <[email protected]>
pablogsal
approved these changes
May 22, 2020
Contributor
Author
|
@lysnikolaou and @pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@lysnikolaou and @pablogsal: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@lysnikolaou and @pablogsal: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message, generated for a non-parenthesized generator expression
in function calls, was still the generic
invalid syntax, when the generator expression wasn't appearing as the first argument in the call. With this patch, even on input likef(a, b, c for c in d, e), the correct error message gets produced.(cherry picked from commit ae14583)
Co-authored-by: Lysandros Nikolaou [email protected]
https://bugs.python.org/issue40334