[doc] Add link to FileHandler in logging (GH-21940) #21940
Conversation
vsajip
left a comment
vsajip
left a comment
There was a problem hiding this comment.
The table contains numerous other references to FileHandler and StreamHandler - I would suggest changing them all to cross-references, or leaving them all as is.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for reviewing, @vsajip I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
vsajip
left a comment
vsajip
left a comment
There was a problem hiding this comment.
Apparently there are conflicts - please resolve.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
|
For some reason, make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W --keep-going -j4" doctest suspicious html is not using the created venv. make htmlview works correctly locally. |
|
I'll close and reopen the pull request to see if that makes a difference. |
vsajip
changed the title
Co-authored-by: Andrés Delfino <[email protected]>
4 participants
No link exists in the doc
Automerge-Triggered-By: @vsajip