Skip to content

bpo-40956: fix sqlite3.Cursor.fetchmany() default value #24214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
berkerpeksag merged 8 commits into from
Jan 13, 2021
Merged

bpo-40956: fix sqlite3.Cursor.fetchmany() default value #24214

berkerpeksag merged 8 commits into from
Jan 13, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 13, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 13, 2021

skip news

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 13, 2021

@berkerpeksag, would you mind reviewing this?

@erlend-aasland erlend-aasland changed the title bpo-40956: fix Cursor.fetchmany() default value bpo-40956: fix sqlite3.Cursor.fetchmany() default value Jan 13, 2021
berkerpeksag
berkerpeksag requested changes Jan 13, 2021
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jan 13, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland erlend-aasland marked this pull request as draft January 13, 2021 21:09
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jan 13, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Jan 13, 2021

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@erlend-aasland erlend-aasland marked this pull request as ready for review January 13, 2021 22:12
@berkerpeksag berkerpeksag merged commit a330365 into python:master Jan 13, 2021
@erlend-aasland erlend-aasland deleted the sqlite-fix-cursor-ac branch January 13, 2021 23:26
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40956: Fix sqlite3.Cursor.fetchmany() default value (pythonGH-24214)
fedd528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @berkerpeksag @the-knights-who-say-ni