bpo-44378: Fix a compiler warning in Py_IS_TYPE() #26644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
erlend-aasland
approved these changes
Jun 10, 2021
hroncok
reviewed
Jun 10, 2021
Contributor
There was a problem hiding this comment.
Suggested change
| :c:func:`Py_IS_TYPE` no longer uses :c:func:`Py_TYPE` to avoid a compiler | |
| :c:func:`Py_IS_TYPE` no longer uses :c:func:`Py_TYPE` to avoid a compiler warning |
Member
Author
There was a problem hiding this comment.
Oops, fixed! I also rewrote the commit message.
Py_IS_TYPE() no longer uses Py_TYPE() to avoid a compiler warning: no longer cast "const PyObject*" to "PyObject*".
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26668 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2021
Py_IS_TYPE() no longer uses Py_TYPE() to avoid a compiler warning: no longer cast "const PyObject*" to "PyObject*". (cherry picked from commit 304dfec) Co-authored-by: Victor Stinner <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 11, 2021
Py_IS_TYPE() no longer uses Py_TYPE() to avoid a compiler warning: no longer cast "const PyObject*" to "PyObject*". (cherry picked from commit 304dfec) Co-authored-by: Victor Stinner <[email protected]>
Member
Author
|
Merged into 3.10 and main branches, thanks for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Py_IS_TYPE() no longer uses Py_TYPE() to avoid a compiler when
casting "const PyObject*" to "PyObject*".
https://bugs.python.org/issue44378