Skip to content

bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2 #26884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 5 commits into from
Jul 14, 2021
Merged

bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2 #26884

miss-islington merged 5 commits into from
Jul 14, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 23, 2021 •
edited by miss-islington
Loading

https://bugs.python.org/issue42064

Automerge-Triggered-By: GH:encukou

@erlend-aasland erlend-aasland requested a review from encukou June 23, 2021 20:11
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021

FYI, for check_cursor and pysqlite_check_connection, we cannot rely on the connection context exception pointers (at least not for the early sanity checks), so I'm using the global state in those methods.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021

(Re-opening to trigger CI again)

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 5, 2021

cc. @encukou

encukou
encukou reviewed Jul 13, 2021
View reviewed changes
Erlend E. Aasland added 2 commits July 13, 2021 23:10
encukou
encukou approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@miss-islington miss-islington merged commit 0516299 into python:main Jul 14, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 14, 2021

Looks good, thanks!

Thanks for reviewing!

@erlend-aasland erlend-aasland deleted the sqlite-move-err/2 branch July 14, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @encukou @the-knights-who-say-ni @bedevere-bot @miss-islington