Skip to content

Fix typo in Counter documentation #29223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 2 commits into from
Oct 28, 2021
Merged

Fix typo in Counter documentation #29223

Fidget-Spinner merged 2 commits into from
Oct 28, 2021

Conversation

@jpetuchovas
Copy link
Contributor

@jpetuchovas jpetuchovas commented Oct 26, 2021

Fixed a small typo in collections documentation related to Counter.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Oct 26, 2021
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 26, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jpetuchovas

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Fidget-Spinner
Fidget-Spinner approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you and welcome to the CPython project :).

@jpetuchovas
Copy link
Contributor Author

jpetuchovas commented Oct 27, 2021

LGTM. Thank you and welcome to the CPython project :).

Thanks for reviewing the pull request!

Fidget-Spinner
Fidget-Spinner reviewed Oct 27, 2021
View reviewed changes
@Fidget-Spinner Fidget-Spinner merged commit 0a68b36 into python:main Oct 28, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 28, 2021

Thanks @jpetuchovas for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
@jpetuchovas @miss-islington
Fix typo in Counter documentation (pythonGH-29223)
b7e2804 
Co-authored-by: Ken Jin <[email protected]>
(cherry picked from commit 0a68b36)

Co-authored-by: Justinas Petuchovas <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Oct 28, 2021

GH-29265 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 28, 2021
miss-islington added a commit that referenced this pull request Oct 28, 2021
@miss-islington @jpetuchovas
Fix typo in Counter documentation (GH-29223)
99495b8 
Co-authored-by: Ken Jin <[email protected]>
(cherry picked from commit 0a68b36)

Co-authored-by: Justinas Petuchovas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpetuchovas @the-knights-who-say-ni @miss-islington @bedevere-bot @Fidget-Spinner