bpo-45723: Add --with-pkg-config to configure (GH-29517) #29517
Conversation
tiran
force-pushed
the
bpo-45723-with-pkg-config
branch
2 times, most recently
from
e6a5f7e to
d0e72b7
Compare
Let users require or ignore pkg-config. ``--with-pkg-config`` makes pkg-config mandatory. ``--without-pkg-config`` disables use of pkg-config. Disabling is also useful to check how configure behaves without pkg-config installed. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-45723-with-pkg-config
branch
from
d0e72b7 to
f1bd071
Compare
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
Looks good. I think a note in Build Changes in What's New would be nice.
| if test -z "$PKG_CONFIG"; then | ||
| dnl invalidate stale config.cache values | ||
| AS_UNSET([PKG_CONFIG]) | ||
| AS_UNSET([ac_cv_path_ac_pt_PKG_CONFIG]) | ||
| AS_UNSET([ac_cv_prog_ac_ct_PKG_CONFIG]) | ||
| fi |
There was a problem hiding this comment.
Unsetting PKG_CONFIG and friends if PKG_CONFIG is not set? Is there a missing ! in the test? Is this check needed at all; the config.cache guard is pretty strict.
There was a problem hiding this comment.
It's un-declaring the variables when it's empty. This solves a corner case when going from ./configure -C --without-pkg-config to ./configure -C --with-pkg-config=yes.
There was a problem hiding this comment.
Maybe you are able to find a better way...
There was a problem hiding this comment.
I see. No, this is fine. I can't think of a better way.
|
Is it worth it listing the packages we actually use |
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
The pkg-config m4 macro will do that for us. |
tiran
changed the title
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
4 participants
Let users require or ignore pkg-config.
--with-pkg-configmakespkg-config mandatory.
--without-pkg-configdisables use ofpkg-config. Disabling is also useful to check how configure behaves
without pkg-config installed.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue45723