bpo-20392: Fix inconsistency with uppercase file extensions in mimetypes.guess_type #30229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Dec 23, 2021
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thanks!
From looking on the original patch, it looks like that you've missed this part:
- The suffixes .tgz, .taz and .tz (case sensitive!) are all
+ The suffixes .tgz, .taz and .tz are allIs it intentional?
Misc/NEWS.d/next/Library/2021-12-22-12-02-27.bpo-20392.CLAFIp.rst
Outdated
Show resolved
Hide resolved
Contributor
Author
I haven't applied that patch and as you commented I even tried to apply it now but it is outdated so not worth copy pasting. |
kumaraditya303
force-pushed
the
issue20392
branch
from
4b59fa0 to
c6a8e05
Compare
kumaraditya303
force-pushed
the
issue20392
branch
from
c6a8e05 to
5fe0a36
Compare
kumaraditya303
requested review from
JelleZijlstra
and removed request for
a team
JelleZijlstra
approved these changes
Mar 11, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks right but I'm not comfortable merging this; I'd like to hear from someone more familiar with MIME types first.
asvetlov
changed the title
asvetlov
approved these changes
Mar 15, 2022
Contributor
|
Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 15, 2022
…pes.guess_type (pythonGH-30229) (cherry picked from commit 5dd7ec5) Co-authored-by: Kumar Aditya <[email protected]>
|
GH-31904 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 15, 2022
…pes.guess_type (pythonGH-30229) (cherry picked from commit 5dd7ec5) Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 15, 2022
…pes.guess_type (GH-30229) (cherry picked from commit 5dd7ec5) Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 15, 2022
…pes.guess_type (GH-30229) (cherry picked from commit 5dd7ec5) Co-authored-by: Kumar Aditya <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…pes.guess_type (pythonGH-30229) (cherry picked from commit 5dd7ec5) Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue20392