[3.9] [3.10] bpo-47040: improve document of checksum functions (GH-31955) (GH-32002) #32004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) (pythonGH-32002) Clarifies a versionchanged note on crc32 & adler32 docs that the workaround is only needed for Python 2 and earlier. Also cleans up an unnecessary intermediate variable in the implementation. Authored-By: Ma Lin / animalize Co-authored-by: Gregory P. Smith <[email protected]> (cherry picked from commit 6d290d5) Co-authored-by: Ma Lin <[email protected]>
Contributor
Author
|
@animalize and @gpshead: Status check is done, and it's a success ✅ . |
gpshead
approved these changes
Mar 20, 2022
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
Contributor
Author
|
@animalize and @gpshead: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@animalize and @gpshead: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies a versionchanged note on crc32 & adler32 docs that the workaround is only needed for Python 2 and earlier.
Also cleans up an unnecessary intermediate variable in the implementation.
Authored-By: Ma Lin / animalize
Co-authored-by: Gregory P. Smith [email protected]
(cherry picked from commit 6d290d5)
Co-authored-by: Ma Lin [email protected]
https://bugs.python.org/issue47040
Automerge-Triggered-By: GH:gpshead