Skip to content

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Mar 20, 2022

Inputs >= 4GiB to binascii.crc32(...) when compiled to use the zlib
crc32 implementation (the norm on POSIX) no longer return the wrong
result.

https://bugs.python.org/issue38256

Inputs >= 4GiB to `binascii.crc32(...)` when compiled to use the zlib
crc32 implementation (the norm on POSIX) no longer return the wrong
result.
@gpshead gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.9 labels Mar 20, 2022
@gpshead gpshead changed the title [3.10] bpo-38256: Fix binascii.crc32 large input. bpo-38256: [3.10] Fix binascii.crc32 large input. Mar 20, 2022
@gpshead gpshead changed the title bpo-38256: [3.10] Fix binascii.crc32 large input. [3.10] bpo-38256: Fix binascii.crc32 large input. Mar 20, 2022
@gpshead gpshead closed this Mar 20, 2022
@gpshead gpshead reopened this Mar 20, 2022
@gpshead gpshead merged commit 4c989e1 into python:3.10 Mar 20, 2022
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@gpshead gpshead deleted the backport-bpo38256-3.10 branch March 20, 2022 21:46
@miss-islington
Copy link
Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4c989e19c84ec224655bbbde9422e16d4a838a80 3.9

gpshead added a commit to gpshead/cpython that referenced this pull request Mar 20, 2022
…ythonGH-32013)

Inputs >= 4GiB to `binascii.crc32(...)` when compiled to use the zlib
crc32 implementation (the norm on POSIX) no longer return the wrong
result.

(cherry picked from commit 4c989e1)
gpshead added a commit that referenced this pull request Mar 21, 2022
…32015)

Inputs >= 4GiB to `binascii.crc32(...)` when compiled to use the zlib
crc32 implementation (the norm on POSIX) no longer return the wrong
result.

(cherry picked from commit 4c989e1)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…-32013) (pythonGH-32015)

Inputs >= 4GiB to `binascii.crc32(...)` when compiled to use the zlib
crc32 implementation (the norm on POSIX) no longer return the wrong
result.

(cherry picked from commit 4c989e1)
@ZeroIntensity ZeroIntensity removed type-bug An unexpected behavior, bug, or error needs backport to 3.9 labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants