bpo-31560: correct hashlib.blake2 keyed hashing example

[dchest]

The example became broken when porting docs from pyblake2.

https://bugs.python.org/issue31560

https://bugs.python.org/issue31560

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

[Mariatta]

Can you create an issue in the bug tracker for this, and the reference the issue number in the PR?
Thanks.
The

[dchest]

@Mariatta done, thanks for pointing out the correct way to do it. (BTW, signed CLA submitted before submitting PR, it probably hasn't been reviewed yet.)

Now, CI error:

Warning, treated as error:
[library/hashlib:502] ":policajac" found in ">>> verify(b'user:policajac', sig)"
make[1]: *** [build] Error 1
make[1]: Leaving directory `/home/travis/build/python/cpython/Doc'
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.

Should I replace it with some non-suspicions English name? (vatrogasac is a firefighter, policajac is a policeman in Serbian).

[dchest]

Replaced usernames with alice and bob and also corrected output format

[Mariatta]

Thanks @dchest :)
Hmm.. I don't quite understand what this error is about .?
Replacing with alice still breaks travis.
@python/crypto-team maybe can offer clues?

[alex]

I don't recognize/understand that error message at all :-/

[dchest]

Let's try to avoid it with -, since cookies should better not contain : anyway.

[dchest]

Nope, still fails, but doesn't even show errors. Should I do this?

Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv. If all issues are false positives, append that file to tools/susp-ignored.csv.

[alex]

I guess so!

…

On Sat, Sep 23, 2017 at 12:50 PM, Dmitry Chestnykh ***@***.*** > wrote: Nope, still fails, but doesn't even show errors. Should I do this? Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv. If all issues are false positives, append that file to tools/susp-ignored.csv. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#3694 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAADBBHokWO4azXovNtD7IfTSSxFxMkIks5slTbMgaJpZM4Pgmgj> .

-- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: D1B3 ADC0 E023 8CA6

[dchest]

I'll need some help there, as I don't quite sure what to include there.

suspicious.py says this:

The file is utf-8 encoded, and each line contains four fields:

 * document name (normalized)
 * line number in the source document
 * problematic text
 * complete line showing the problematic text in context

But since the checker doesn't show what the problematic text is now, I'm not sure how to exclude it.

[benjaminp]

The "error" is that the suspicious exceptions for hashlib no longer apply. You should simply remove them from Doc/tools/susp-ignored.csv.

[dchest]

Aaaah! Thanks, @benjaminp !

[miss-islington]

Thanks @dchest for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

[dchest]

Awesome, thank you!

[miss-islington]

Thanks @dchest for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

[miss-islington]

Sorry, @dchest and @benjaminp, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aecc08ac3a14a73aa353655bb65ff8d965e935a0 3.6