bpo-13631: Fix the order of initialization for readline/editline.

[zvezdan]

The editline emulation needs to be initialized after the name is
defined. This fixes the long open issue.

https://bugs.python.org/issue13631

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

[zvezdan]

I added my GitHub username to my b.p.o. profile.
Please re-run the bot.

[ned-deily]

In general, it looks pretty good (other than the couple of nits) and it works! Thanks for making the PR and not giving up. It would be nice to have a test case for it added to Lib/test/test_readline.py so we don't break it again but it might be challenging to construct such a test so I wouldn't insist on it.

[ned-deily]

There is another libedit-specific note in readline.rst just a few lines above this one. Rather than adding a second note, I think it would make more sense to just have one combined one and it may make more sense to move the existing note down to this position.

[ned-deily]

This is a bit too verbose for a NEWS entry. The first sentence is sufficient; suggest removing from "For example" on.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[ned-deily]

One other issue, which I just noticed. The Python doc builder has a checker tool that checks for potential problems in the doc source files. The check is run with make -C doc suspicious and is run as part of the CI tests. The checker looks for anything that might be a misspelled Docutils/Sphinx role and so fails on the python:bind ... examples you add. To silence the warnings, you should make the following additions to Doc/tools/susp-ignored.csv in your PR:

--- a/Doc/tools/susp-ignored.csv
+++ b/Doc/tools/susp-ignored.csv
@@ -187,6 +187,8 @@ library/profile,,:lineno,filename:lineno(function)
 library/pyexpat,,:elem1,<py:elem1 />
 library/pyexpat,,:py,"xmlns:py = ""http://www.python.org/ns/"">"
 library/random,,:len,new_diff = mean(combined[:len(drug)]) - mean(combined[len(drug):])
+library/readline,,:bind,"python:bind -v"
+library/readline,,:bind,"python:bind ^I rl_complete"
 library/smtplib,,:port,method must support that as well as a regular host:port
 library/socket,,::,'5aef:2b::8'
 library/socket,,:can,"return (can_id, can_dlc, data[:can_dlc])"

[zvezdan]

Ned, thanks a lot for reviewing.
I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

[miss-islington]

Thanks @zvezdan for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

[bedevere-bot]

GH-6928 is a backport of this pull request to the 3.7 branch.

[vstinner]

Oh. I started to review the change and it has just been merged, nice :-)

Thank you Zvezdan Petkovic (@zvezdan) and congrats for your first PR merged into CPython! ✨ 🍰 ✨