Skip to content

[3.6] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826) #7528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Jun 8, 2018
Merged

[3.6] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826) #7528

miss-islington merged 1 commit into from
Jun 8, 2018

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 8, 2018 •
edited by bedevere-bot
Loading

  • bugfix and test for fragile metavar handling in argparse (see
    bpo-24089, bpo-14046, bpo-25058, bpo-11874)
  • also fixes some incorrect tests that did not make 1-element tuples correctly
    (cherry picked from commit 66f02aa)

Co-authored-by: wim glenn [email protected]

https://bugs.python.org/issue11874

@wimglenn @miss-islington
bpo-11874: fix assertion failure in argparse metavar handling (python…
6967101 
…GH-1826)

- bugfix and test for fragile metavar handling in argparse (see
  bpo-24089, bpo-14046, bpo-25058, bpo-11874)
- also fixes some incorrect tests that did not make 1-element tuples correctly
(cherry picked from commit 66f02aa)

Co-authored-by: wim glenn <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2018
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Jun 8, 2018

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Jun 8, 2018

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 376c272 into python:3.6 Jun 8, 2018
@miss-islington
Copy link
Contributor Author

miss-islington commented Jun 8, 2018

Thanks!

@miss-islington miss-islington deleted the backport-66f02aa-3.6 branch June 8, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @ncoghlan @the-knights-who-say-ni @bedevere-bot @wimglenn