gh-91078: Return None from TarFile.next when the tarfile is empty #91850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Would this need to be backported? |
AlexWaygood
added
the
stdlib
iritkatriel
approved these changes
Nov 26, 2022
Member
iritkatriel
left a comment
iritkatriel
left a comment
There was a problem hiding this comment.
LGTM.
@ethanfurman what's your view on back porting this?
iritkatriel
changed the title
ethanfurman
approved these changes
Nov 26, 2022
Contributor
|
Thanks @dignissimus for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-99798 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 26, 2022
…ty (pythonGH-91850) (cherry picked from commit 78365b8) Co-authored-by: Sam Ezeh <[email protected]> Co-authored-by: Irit Katriel <[email protected]>
Member
|
@iritkatriel Backporting sounds good, thanks for the help. @dignissimus Thanks for the work, sorry it took so long to get merged. |
miss-islington
added a commit
that referenced
this pull request
Nov 26, 2022
…-91850) (cherry picked from commit 78365b8) Co-authored-by: Sam Ezeh <[email protected]> Co-authored-by: Irit Katriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91078