Skip to content

GH-91173: disable frozen modules in debug builds #92023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 5 commits into from
May 3, 2022
Merged

GH-91173: disable frozen modules in debug builds #92023

gvanrossum merged 5 commits into from
May 3, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 28, 2022 •
edited
Loading

Closes #91173

@kumaraditya303 kumaraditya303 marked this pull request as draft April 28, 2022 16:19
gvanrossum
gvanrossum reviewed Apr 28, 2022
View reviewed changes
@kumaraditya303 kumaraditya303 marked this pull request as ready for review May 2, 2022 13:00
@kumaraditya303 kumaraditya303 requested a review from gvanrossum May 2, 2022 13:03
gvanrossum
gvanrossum approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Will land.

@gvanrossum gvanrossum merged commit e8d7661 into python:main May 3, 2022
@kumaraditya303 kumaraditya303 deleted the fix-frozen-modules branch May 4, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

frozen modules are on by default in dev build

3 participants

@kumaraditya303 @gvanrossum @bedevere-bot