gh-92128: Add __class_getitem__ to logging.LoggerAdapter and logging.StreamHandler
#92129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
type-feature
Member
Author
|
Previous changes like this have not made changes to the docs to note the addition of |
This was referenced May 1, 2022
JelleZijlstra
approved these changes
May 1, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good, I checked the stubs and it makes sense that these classes are generic.
I do think we should document that these classes are generic and say how many type arguments to expect and what they mean. We should do that more broadly for generic classes, though, and I'd rather get the runtime change in before the feature freeze.
vsajip
approved these changes
May 2, 2022
kumaraditya303
approved these changes
May 2, 2022
AlexWaygood
commented
May 2, 2022
Misc/NEWS.d/next/Library/2022-05-01-21-45-41.gh-issue-92128.Di7VbE.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
approved these changes
May 2, 2022
Member
Author
|
Thanks all for the speedy reviews! |
This was referenced May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92128