Skip to content

Conversation

@pfmoore
Copy link
Member

@pfmoore pfmoore commented Jun 24, 2022

Fixes #94214.

This adds the libpath of the new virtual environment to the context object returned by ensure_directories, and documents the context object so that callers can use it to introspect the newly-created environment.

I haven't added tests for this, but should we do so as we're now documenting the context?

@pfmoore pfmoore requested a review from vsajip as a code owner June 24, 2022 14:21
@pfmoore pfmoore changed the title Add venv context.lib_path and document the context gh-94214: Add venv context.lib_path and document the context Jun 24, 2022
@vsajip vsajip changed the title gh-94214: Add venv context.lib_path and document the context gh-94214: Add venv context.lib_path and document the context (GH-94221) Jun 26, 2022
@vsajip vsajip merged commit aedb519 into python:main Jun 26, 2022
@pfmoore pfmoore deleted the venv_context branch June 26, 2022 18:09
@pfmoore
Copy link
Member Author

pfmoore commented Jun 26, 2022

Awesome! Thanks for the quick review and merge 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose libpath in venv.EnvBuilder.ensure_directories return value

3 participants