Skip to content

gh-87822: Make traceback module robust to exceptions from repr() of local values #94691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 8 commits into from
Jul 11, 2022
Merged

gh-87822: Make traceback module robust to exceptions from repr() of local values #94691

iritkatriel merged 8 commits into from
Jul 11, 2022

Conversation

@moi90
Copy link
Contributor

@moi90 moi90 commented Jul 8, 2022 •
edited by bedevere-bot
Loading

@moi90 moi90 requested a review from iritkatriel as a code owner July 8, 2022 15:49
@iritkatriel iritkatriel changed the title gh-87822: Make FrameSummary robust to unrepresentable values gh-87822: Make traceback module robust to exceptions from repr() of local values Jul 8, 2022
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory 3.12 only security fixes labels Jul 8, 2022
iritkatriel
iritkatriel reviewed Jul 8, 2022
View reviewed changes
iritkatriel
iritkatriel reviewed Jul 8, 2022
View reviewed changes
@moi90
Copy link
Contributor Author

moi90 commented Jul 10, 2022

Thanks for the feedback! I made the requested changes.

iritkatriel
iritkatriel reviewed Jul 10, 2022
View reviewed changes
iritkatriel
iritkatriel reviewed Jul 10, 2022
View reviewed changes
@iritkatriel iritkatriel merged commit 46fc584 into python:main Jul 11, 2022
@moi90 moi90 deleted the fix-87822 branch July 12, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

4 participants

@moi90 @iritkatriel @arhadthedev @bedevere-bot