gh-96497: Mangle name before symtable lookup in 'symtable_extend_namedexpr_scope' #96561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
EDIT: Seems rerunning the checks fixed it. Thanks. |
Contributor
Author
|
Hi, would anyone be able to give this PR a review? |
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @wookie184 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…d_namedexpr_scope' (pythonGH-96561) (cherry picked from commit 664965a) Co-authored-by: wookie184 <[email protected]>
|
GH-115603 is a backport of this pull request to the 3.12 branch. |
|
Sorry, @wookie184 and @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
…nd_namedexpr_scope' (GH-96561) (GH-115603) (cherry picked from commit 664965a) Co-authored-by: wookie184 <[email protected]>
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Feb 17, 2024
…e_extend_namedexpr_scope' (pythonGH-96561) (cherry picked from commit 664965a) Co-authored-by: wookie184 <[email protected]>
|
GH-115604 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 17, 2024
…nd_namedexpr_scope' (GH-96561) (GH-115604) (cherry picked from commit 664965a) Co-authored-by: wookie184 <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…d_namedexpr_scope' (pythonGH-96561)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…d_namedexpr_scope' (pythonGH-96561)
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…d_namedexpr_scope' (pythonGH-96561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96497
Previously, the non-mangled name was being looked up for assignment expressions in comprehensions, which caused some bugs. See issue for more information.