Skip to content

gh-94943: [Enum] improve repr() when inheriting from a dataclass #99740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ethanfurman merged 4 commits into from
Dec 6, 2022
Merged

gh-94943: [Enum] improve repr() when inheriting from a dataclass #99740

ethanfurman merged 4 commits into from
Dec 6, 2022

Conversation

@ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Nov 23, 2022 •
edited by bedevere-bot
Loading

When inheriting from a dataclass, only show the field names in the value section of the member repr(), and not the dataclass' class name.

@ethanfurman
add dataclass support
a8d87a7 
When inheriting from a dataclass, only show the field names in the value
section of the member repr(), and not the dataclass' class name.
@ethanfurman
add more tests
ee8cfc4
@bedevere-bot bedevere-bot mentioned this pull request Nov 23, 2022
Closed
@ethanfurman ethanfurman self-assigned this Nov 23, 2022
@ethanfurman
Copy link
Member Author

ethanfurman commented Nov 24, 2022

Should probably have a way to keep a dataclass-generated repr.

@CAM-Gerlach CAM-Gerlach added type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory 3.12 only security fixes labels Nov 24, 2022
CAM-Gerlach
CAM-Gerlach reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some relatively minor syntax and textual fixes, clarifications and refinements on the docs and NEWS entry, thanks.

@ethanfurman ethanfurman merged commit 679efbb into python:main Dec 6, 2022
@ethanfurman ethanfurman deleted the enum-dataclass branch February 1, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees

@ethanfurman ethanfurman

Labels

3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanfurman @CAM-Gerlach @bedevere-bot