Consider non-empty enums assignable to Self #19779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Sep 2, 2025
A5rocks
reviewed
Sep 3, 2025
| self.fail("Self type cannot be used in a metaclass", t) | ||
| if self.api.type.self_type is not None: | ||
| if self.api.type.is_final: | ||
| if self.api.type.is_final or self.api.type.is_enum and self.api.type.enum_members: |
Collaborator
There was a problem hiding this comment.
Should enums have is_final set maybe, so they opt into all behaviors like this?
Member
There was a problem hiding this comment.
Yeah, I was thinking about this. We can try this in a separate PR (this may also simplify a bit some of the mypyc code related to final enums).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18345.
Fixes #16558.
See the linked ticket for reasoning - enums with members are implicitly final and should be treated exactly as if they were decorated with
@final.