Support types as converters in attrs plugin #4917
Conversation
|
This unblocks: python-attrs/attrs#238 |
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Thank you for adding this! I went ahead and changed the type annotation to a type comment and I left a few requests w.r.t. the tests.
| [file a.py] | ||
| from typing import overload | ||
| import attr | ||
| class complex: |
There was a problem hiding this comment.
Especially since it is duplicated across several test cases, moving this to a fixture would be good.
test-data/unit/check-attr.test
Outdated
| from typing import overload | ||
| import attr | ||
|
|
||
| class complex: |
There was a problem hiding this comment.
Perhaps this should be moved to a fixture?
| class complex: | ||
| @overload | ||
| def __init__(self, re: float = 0.0, im: float = 0.0) -> None: ... | ||
| @overload |
There was a problem hiding this comment.
Could you also add tests for an overloaded converter function?
There was a problem hiding this comment.
Thanks for this note. It was actually broken!
|
Thanks for the review! I've addressed all your concerns and fixed some more things that were broken. |
|
@ethanhs is there a way to re-request review that I'm missing here? |
|
Thank you again for working on this @euresti ! |
4 participants
Fixes #4729