Refactoring: Cleanup DataSuite fields #5075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Default base_path to test_temp_dir * Rename optional_out to required_out_section and default to False * Remove update_data, and inline the only place it is used * Document reason for data_prefix
msullivan
reviewed
May 18, 2018
mypy/test/data.py
Outdated
|
|
||
| base_path = test_temp_dir | ||
|
|
||
| # Allow mypyc to update to using a recent version of mypy. See #4779 |
Collaborator
There was a problem hiding this comment.
I would say "Allow external users of the test code to override the data prefix" or something
msullivan
approved these changes
May 19, 2018
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple changes to DataSuite, I believe they make things somewhat more readable and explicit.
base_pathtotest_temp_dir; this clearly marks tests that do something unusualoptional_outtorequired_out_sectionand default toFalseupdate_data, and inline the only place it is used. The flag might be reintroduced if the functionality will be shared with other suitesdata_prefix, since it is not written anywhere