Implement CAA resource record #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements handling of CAA resource records defined by [RFC8659]. - There are no known deployment of CAA records outside of IN (Internet), but the RFC does not state that CAA records are class-specific. Thus `CAA` class is defined as a class-independent RRType. - `CAA` class stores `flags` field (a 1-octet bitset) as an Integer. In this way it's easier to ensure the encoded RR is in the valid wire format. [RFC8659]: https://datatracker.ietf.org/doc/html/rfc8659 Co-authored-by: aeris <[email protected]>
Closed
Contributor
Author
|
The failing test looks unrelated to this patch: https://github.com/ruby/resolv/actions/runs/8078401965/job/22070645994?pr=48 |
Member
|
Yes, Windows platform failed sometimes with |
sorah
approved these changes
Feb 29, 2024
Contributor
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements handling of CAA resource records defined by RFC8659.
Based on ruby/ruby#1732 by @aeris, with tests added and some changes:
CAAclass is defined as a class-independent RRType.CAAclass storesflagsfield (a 1-octet bitset) as an Integer. In this way it's easier to ensure the encoded RR is in the valid wire format.