Mark strings returned by Symbol#to_s as chilled #12065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
shared-to-fl-user-0
branch
from
8623479 to
478e3e1
Compare
This comment has been minimized.
This comment has been minimized.
casperisfine
force-pushed
the
shared-to-fl-user-0
branch
from
478e3e1 to
eddd9ad
Compare
Member
Yes, changing the values/definitions of macros is definitely ABI-incompatible, so it should be bumped. |
Contributor
Author
|
@eregon would you happen to remember where it's set. |
casperisfine
force-pushed
the
shared-to-fl-user-0
branch
from
eddd9ad to
99f0e9b
Compare
maximecb
approved these changes
Nov 12, 2024
This makes space in RString for two bits for chilled strings.
casperisfine
force-pushed
the
shared-to-fl-user-0
branch
from
99f0e9b to
e96290c
Compare
[Feature #20350] `STR_CHILLED` now spans on two user flags. If one bit is set it marks a chilled string literal, if it's the other it marks a `Symbol#to_s` chilled string. Since it's not possible, and doesn't make much sense to include debug info when `--debug-frozen-string-literal` is set, we can't include allocation source, but we can safely include the symbol name in the warning message, making it much easier to find the source of the issue. Co-Authored-By: Étienne Barrié <[email protected]>
casperisfine
force-pushed
the
shared-to-fl-user-0
branch
from
e96290c to
68d1968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #20350]
STR_CHILLEDnow spans on two user flags. If one bit is set it marks a chilled string literal, if it's the other it marks aSymbol#to_schilled string.Since it's not possible, and doesn't make much sense to include debug info when
--debug-frozen-string-literalis set, we can't include allocation source, but we can safely include the symbol name in the warning message, making it much easier to find the source of the issue.cc @jhawthorn @eregon
@peterzhu2118 do you know if I should bump the ABI version given some flags were moved around?