[Misc #18984] Raise TypeError from Range#size if the range is not iterable
#8663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Apologies that this was not reviewed in a timely fashion. Could you rebase and update the specs to they apply to Ruby 3.4 instead of 3.3? Also, in the specs, please remove |
kyanagi
force-pushed
the
range_size_type_error
branch
from
1544a46 to
9412950
Compare
Contributor
Author
|
@jeremyevans Thank you for your review! |
matz
added a commit
to mruby/mruby
that referenced
this pull request
May 29, 2024
According ruby/ruby#8663, `Range#size` behavior has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/18984
https://github.com/ruby/dev-meeting-log/blob/master/2023/DevMeeting-2023-10-12.md