Skip to content

Conversation

@jeremyevans
Copy link
Contributor

nil is treated similar to the empty hash in this case, passing no keywords and not calling any conversion methods.

Fixes [Bug #20064]

@jeremyevans jeremyevans requested a review from k0kubun January 10, 2024 23:23
@k0kubun
Copy link
Member

k0kubun commented Jan 10, 2024

jeremyevans requested a review from k0kubun 4 minutes ago

I'm not sure how I'm relevant to this change. Are you asking me to add YJIT/RJIT support or something?

@jeremyevans
Copy link
Contributor Author

jeremyevans requested a review from k0kubun 4 minutes ago

I'm not sure how I'm relevant to this change. Are you asking me to add YJIT/RJIT support or something?

No, you just came up first in the GitHub list. :) You can ignore.

@jeremyevans jeremyevans requested review from nobu and removed request for k0kubun January 10, 2024 23:34
@k0kubun
Copy link
Member

k0kubun commented Jan 10, 2024

Thanks. Maybe GitHub thinks I did many contributions to the file because I expanded tabs 🙂 Nobu or Koichi would be a better reviewer for this change.

@jeremyevans
Copy link
Contributor Author

Only failure is TravisCI on ppc64le Linux, where it passed test-spec and test-all, but not test: https://app.travis-ci.com/github/ruby/ruby/jobs/616119319#L2006 (with no output)

@jeremyevans
Copy link
Contributor Author

This needs more work to handle {**nil}, f(a: 1, **nil), and other cases. I'll work on that later today.

jeremyevans and others added 4 commits January 14, 2024 10:58
nil is treated similar to the empty hash in this case, passing
no keywords and not calling any conversion methods.

Fixes [Bug #20064]
Co-authored-by: Nobuyoshi Nakada <[email protected]>
@jeremyevans jeremyevans force-pushed the nil-keyword-splat-20064 branch from 5c11591 to 73f8121 Compare January 14, 2024 18:58
@jeremyevans jeremyevans merged commit 5c823aa into ruby:master Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants