-
Notifications
You must be signed in to change notification settings - Fork 29
added the check for negative sec #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, could you add tests for this? |
…r and added tests
…r and added tests
|
Could you also update the docs? |
jeremyevans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. I agree we should raise for negative numbers, as you can make the argument that the timeout has already expired. It's arguable whether we should raise Timeout::Error (or klass) in this case, instead of ArgumentError, but I'm not opposed to using ArgumentError. I do have a couple inline requests for changes.
Co-authored-by: Jeremy Evans <[email protected]>
Co-authored-by: Jeremy Evans <[email protected]>
|
Sorry I missed approving this a few days ago. Thanks for the reminder! |
|
@eregon whenever you find time, I’d greatly appreciate your review on the updated changes, thank you for your guidance! |
|
LGTM, thanks for the review @jeremyevans |
Potential issues with current behaviour:
I suggest this change for the consistent behaviour regardless of code-block as well as the clear indication of the source of the error