Add support for Fiber::Scheduler#blocking_operation_wait.
#352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
olleolleolle
reviewed
Nov 7, 2024
ioquatix
force-pushed
the
scheduler-blocking_operation_wait
branch
3 times, most recently
from
669cf4c to
d4af544
Compare
ioquatix
force-pushed
the
scheduler-blocking_operation_wait
branch
from
d4af544 to
2217b1a
Compare
ioquatix
force-pushed
the
scheduler-blocking_operation_wait
branch
from
7477c21 to
4b0ff84
Compare
Member
Author
|
Confirmed tests passing on ruby-head. |
|
Does this mean that every time something releases the GVL, async will create a new thread? |
Member
Author
|
Yes the current implementation is a bit naive. I’ll implement a thread pool if it makes sense to do so. The overhead of thread creation isn’t so bad though - will need to spend some time testing it. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic implementation of the
Fiber::Scheduler#blocking_operation_waithook.See https://bugs.ruby-lang.org/issues/20876 for more context.
Types of Changes
Contribution