Resolve ruby 2.7 warnings #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ruby 3.0 positional arguments and keyword arguments will be separated, and to prepare us for this, ruby 2.7 will start raising warnings about potential issues. This change resolves most of the warnings in the test-suite and some that we have noticed in production.
jurre
force-pushed
the
jurre/ruby-27-warnings
branch
from
7c14162 to
a6b5f5f
Compare
Contributor
Author
|
It seems like that kafka-2.5 failure is a known flake? Lmk if I need to look into it instead! |
Contributor
Author
|
Hi @dasch, anything I can do to help get these changes in? 💛 |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ruby 3.0 positional arguments and keyword arguments will be
separated, and to prepare us for this, ruby 2.7 will start raising
warnings about potential issues.
This change resolves most of the warnings in the test-suite and some
that we have noticed in production.
I bumped .ruby-version for testing and kept it in this PR to make verifying
the changes locally a bit easier, but CI runs everything on 2.5.1 so might
be better to revert that, or update CI to run on 2.7. Happy to update the
PR to accomodate either.