Unable to set RuleSuppressionID in DiagnosticRecord object from custom powershell rule

[jegannathanmaniganadan]

I have been trying to set RuleSuppressionID in the [Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord]::new() object from a custom Powershell rules. But for some reason that is not working. Not sure if PSSA removes the property before writing it out

I could see that DiagnosticRecord constructor takes value for RuleSuppressionID.

{
            Message  = message;
            RuleName = ruleName;
            Extent   = extent;
            Severity = severity;
            ScriptPath = scriptPath;
            RuleSuppressionID = ruleId;
            this.suggestedCorrections = suggestedCorrections;
}

@bergmeister

[bergmeister]

@manigandan-jegannathan-developer Yes, that could be. This reminds of this PR where I had to set the SuggestedCorrections property for custom rules because otherwise it got lost in translation. By looking at the code here it seems to be quite clear that the RuleSuppressionID does not get translated. Since this is an easy one, I opened a PR for this below (also to show you how easy it is to make changes)

[jegannathanmaniganadan]

@bergmeister Thanks for the PR. I thought of creating one.