Skip to content

Conversation

@MartinGC94
Copy link
Contributor

PR Summary

Fixes type inference when accessing indexes of ICollection types like System.Security.AccessControl.AuthorizationRuleCollection for scenarios like (Get-Acl).Access[0].<Tab>
It looks like someone switched two variables around by mistake. I also added a comment to the if statement to explain why it's not doing something the "obvious" way.

PR Context

PR Checklist

@MartinGC94 MartinGC94 requested a review from daxian-dbw as a code owner July 23, 2022 18:32
@MartinGC94 MartinGC94 closed this Jul 23, 2022
@MartinGC94 MartinGC94 reopened this Jul 23, 2022
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 24, 2022
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 5ccbb97 into PowerShell:master Jul 25, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants