Skip to content

Replacing datastore pb uses with query shim. - #1299

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:datastore-query-file-shim
Dec 17, 2015
Merged

Replacing datastore pb uses with query shim.#1299
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:datastore-query-file-shim

Conversation

@dhermes

@dhermes dhermes commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

This is just a superficial rename in preparation for v1beta3.

This is just a superficial rename in preparation
for v1beta3.
@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 17, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2015
@dhermes dhermes mentioned this pull request Dec 17, 2015
49 tasks
@tseaver

tseaver commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Dec 17, 2015
Replacing datastore pb uses with query shim.
@dhermes
dhermes merged commit b2f5d6c into googleapis:master Dec 17, 2015
@dhermes
dhermes deleted the datastore-query-file-shim branch December 17, 2015 16:49
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* chore: update token

* chore: update token
parthea pushed a commit that referenced this pull request Mar 6, 2026
* Updates minor grammatical error

* chore: update grammar/spelling
daniel-sanche pushed a commit that referenced this pull request Sep 4, 2026
**Changes Made:**
- Added methods to convert `Row` and `Cell` objects in the data client
to `PartialRowData` and `Cell` objects in the legacy client.
- Removed legacy client code related to processing `ReadRowResponse`
chunks and testing `ReadRowResponse` chunks.
- Removed `_update_message_request` from `RowSet` because it's no longer
needed to create a `ReadRowQuery`
- Rerouted `read_row` and `read_rows` to use their data client
counterparts in `table.py`.
daniel-sanche pushed a commit that referenced this pull request Sep 4, 2026
**Changes Made:**
- Added methods to convert `Row` and `Cell` objects in the data client
to `PartialRowData` and `Cell` objects in the legacy client.
- Removed legacy client code related to processing `ReadRowResponse`
chunks and testing `ReadRowResponse` chunks.
- Removed `_update_message_request` from `RowSet` because it's no longer
needed to create a `ReadRowQuery`
- Rerouted `read_row` and `read_rows` to use their data client
counterparts in `table.py`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants