Detect exotic assignment patterns to JS prototypes

[a-ejs]

Template added by by Matt Bierner (@mjbvz)

TS Versions: 3.7-20190911

Repo
For the JS:

function A() {}

A.prototype.foo = 1;

[A.prototype.bar] = [2],
{baz: A.prototype.baz} = {baz: 3};

const proto = A.prototype;
proto.prop = 4;

Expected
Intellisense for instances of A should show four properties

Actual
Only foo shown.

Original report below

Intellisense seems to only recognize straightforward prototype property definitions like Class.prototype.prop = value.

Assigning Class.prototype to a variable and extending that, or using destructuring syntax will not be recognized by it:

[mjbvz]

Please share the text of the code along with screenshots

/needsMoreInfo

[vscodebot]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[a-ejs]

Here's the code:

function A() {}

A.prototype.foo = 1;

[A.prototype.bar] = [2],
{baz: A.prototype.baz} = {baz: 3};

const proto = A.prototype;
proto.prop = 4;

This will create a prototype with 4 properties on it, but Intellisense only suggests one, foo.

[RyanCavanaugh]

Is there a reason someone would write code this way?

[a-ejs]

Assigning prototype to a variable is not an uncommon code pattern in my experience (repeating VeryLongClassName.prorotype for every assignment can look bulky), and destructuring syntax can be useful to extend the prototype with imports from another file.

[RyanCavanaugh]

I don't think we'll ever be able to detect indirected forms like const proto = A.prototype;. The others... well, we could, but it really doesn't seem like the is common at all.