Code actions "Move to file" and "Move to new file" are shown everywhere

[jrieken]

• open this file
• select data
• select light bulb
• 🐛 there is entries for "Move to file" and "Move to new file"

[justschen]

It's unrelated to editor.codeActionWidget.includeNearbyQuickFixes, but this does happen in every file.

imo, maybe the lightbulb shouldn't show for non-fix actions? if it's only move..., i can see how that can be annoying.

vs like how we have this one to indicate quickfixable actions.

[jrieken]

imo, maybe the lightbulb shouldn't show for non-fix actions? if it's only move..., i can see how that can be annoying.

I wouldn't declare this as a generic light bulb issue, yet. Having refactoring sold by it does makes sense but it shouldn't be as spammy as it is today with 'Move...'. It seem they show unconditionally (like for loop counters or semicolons) and would benefit from some self-control, e.g only show when on a method, function, class etc ppp

[justschen]

Johannes Rieken (@jrieken) atm, it is just shown in every non-empty line in a method, class, function, etc. and in some files, that means the entire file and nearly every line.

Could maybe play around with only having it to show up at the line of function/class/methoid declaration, but not in the code body? Not sure if Matt Bierner (@mjbvz) has any opinions on this.

[mjbvz]

Some ideas:

• Only show the lightbulb (implicit code action) when on declarations
• Maybe still keep showing these actions if refactorings are explicitly requested
• In the refactoring label, show the name of what is going to be moved. Right now it makes is seem like the loop itself will get moved

[jrieken]

Only show the lightbulb (implicit code action) when on declarations

💯 on that - showing the code action further down is noise and lowers my trust in light bulb being helpful (and not ad-space)

[aiday-mar]

HI Nathan Shively-Sanders (@sandersn), I would like to have a go at this PR. Could I have a pointer to place in the code where the change should be, or discuss this issue with one of your team members in a meeting? We are currently looking into displaying code actions in the light-bulb menu in VS Code on empty lines too, and currently we are seeing the Move to file and Move to new file actions appearing very often. I had initially prepared a PR to patch this issue on the VS Code side, but we think ideally this fix should come directly from TypeScript

[sandersn]

Aiday Marlen Kyzy (@aiday-mar) I believe navya9singh and Andrew Branch (@andrewbranch) have worked the most on Move To File.