Problem Building Node (had errors about multiply-defined symbols and such)

[DragonOsman]

• Version: Currently 11.1.0, but am installing 11.2.0
• Platform: Windows 10 Home Single Language
• Subsystem: Need to build Node (pulled from Node GitHub repo)

I went into my Node root with the .git folder and ran .\vcbuild, and it built a lot of the stuff but then ended with the errors:

zlib.lib(adler32.obj) : error LNK2005: adler32 already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(adler32.obj) : error LNK2005: adler32_combine already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(adler32.obj) : error LNK2005: adler32_z already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32 already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32_combine already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32_z already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: get_crc_table already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
C:\node\Release\node.exe : fatal error LNK1169: one or more multiply defined symbols found [C:\node\node.vcxproj]

I want to build Node and then V8. Any help would be greatly appreciated.

[refack]

Hello @DragonOsman and thank you for the report.
It seems like you computer has a previously installed zlib1.dll, and it's added the the linker's LIBPATH so it finds two library files that defines those symbols (your zlib1.dll and the zlib.lib we build from our tree).

1. One option is to disable you globally installed zlib (it's usually installed with Chocolatery or NuGet)
2. Another option is to run the configure script with --shared-zlib:

python configure --shared-zlib --with-pch --dest-cpu=x64 --verbose
                 ^^^^^^^^^^^^^

[DragonOsman]

Thanks for the reply. I'll try the second option.

By the way, I forgot to mention earlier that I'm using Visual Studio 2017 (latest version).

[DragonOsman]

I have these warnings:

rand_egd.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\node\deps\openssl\openssl.vcxproj]
ecp_nistputil.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\node\deps\openssl\openssl.vcxproj]
ecp_nistp521.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\node\deps\openssl\openssl.vcxproj]
ecp_nistp256.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\node\deps\openssl\openssl.vcxproj]
ecp_nistp224.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\node\deps\openssl\openssl.vcxproj]
ebcdic.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\node\deps\openssl\openssl.vcxproj]

Do I need to worry?

[refack]

Do I need to worry?

No, it's expected. I often see it while building locally.

[DragonOsman]

I got the same errors again:

zlib.lib(adler32.obj) : error LNK2005: adler32 already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(adler32.obj) : error LNK2005: adler32_combine already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(adler32.obj) : error LNK2005: adler32_z already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32 already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32_combine already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32_z already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: get_crc_table already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
C:\node\Release\node.exe : fatal error LNK1169: one or more multiply defined symbols found [C:\node\node.vcxproj]

How do I disable the other zlib installation?

[refack]

You can try:

[DragonOsman]

I had zlib installed in the C drive in a folder called "libraries". I completely deleted that folder and then tried to build Node again, but had the same errors as before.

[refack]

2. Another option is to run the configure script with --shared-zlib:

python configure --shared-zlib --with-pch --dest-cpu=x64 --verbose
                 ^^^^^^^^^^^^^

What I forgot to say is that if you build with vcbuild.bat then you need to set an env var config_flags. So:

set config_flags=--shared-zlib
vcbuild release x64

[DragonOsman]

I even removed the vcpkg for zlib from my system and tried to build again with the commands you just gave. Got these errors at the end:

LINK : fatal error LNK1181: cannot open input file 'z.lib' [C:\node\tools\icu\icupkg.vcxproj]
LINK : fatal error LNK1181: cannot open input file 'z.lib' [C:\node\tools\icu\iculslocs.vcxproj]
LINK : fatal error LNK1181: cannot open input file 'z.lib' [C:\node\tools\icu\genccode.vcxproj]
LINK : fatal error LNK1181: cannot open input file 'z.lib' [C:\node\tools\icu\genrb.vcxproj]

Any ideas?

[refack]

Any ideas?

So it's either/or. If you removed the global zlib.dll you need to build the "in tree" version (i.e. "not share zlib"):

set config_flags=
vcbuild release x64

If that doesn't work, try searching your whole computer for zlib.dll and rename them all.

[DragonOsman]

Got the same errors.

So what do you mean by renaming them all? What should I rename them to? And what if I just delete them all?

I wonder if you could help me with compiling a C++ webserver app I have to WebAssembly? I want to use it on the backend as a Node.js module. I can't get em++ to generate .wasm code for it, though. I get .o and .js, but no .wasm. The source code is here: https://github.com/DragonOsman/currency_converter , and the command I used is:

em++ -std=c++17 -Wall -pedantic -D variant_CONFIG_SELECT_VARIANT=variant_VARIANT_NONSTD -I C:/Jinja2Cpp/install_x64/include -I C:/json/single_include -I C:/boost_1_68_0/ -I C:/Users/Osman/emsdk/emscripten/1.38.18/system/include/ currency_converter.cpp -L C:/Jinja2Cpp/install_x64/lib/static/jinja2cpp.lib -L C:/boost_1_68_0/lib64-msvc-14.1/libboost_system-vc141-mt-x64-1_68.lib -lpthread -o currency_converter.js -o currency_converter.o currency_converter.js -s WASM=1 -s DISABLE_EXCEPTION_CATCHING=0 -s USE_PTHREADS=1

I understand that when wanting to call embind for std::shared_ptr in JavaScript code, one has to use EMSCRIPTEN_BINDINGS and some other code in there to be able to do it. Does this apply to Node.js? Could this be why it won't generate WebAssembly code? If so, how do I use EMSCRIPTEN_BINDINGS on std::make_shared_from_this<>? I want to use the one that will let the pointer translate to an actual std::shared_ptr on the Node.js side rather than a regular, raw pointer.

I also tried asking about this in the emsdk GitHub. That's here (the two replies there is just me giving more info and updates) and here. I also asked something else two months ago about cwrap, and I asked about this there as well: link. As you can see, I don't have replies on the latest comments I made. If you can help me on this, that'd be great.

Note: The "same errors" I mentioned before are the same ones I was getting at first:

zlib.lib(adler32.obj) : error LNK2005: adler32 already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(adler32.obj) : error LNK2005: adler32_combine already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(adler32.obj) : error LNK2005: adler32_z already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32 already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32_combine already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: crc32_z already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
zlib.lib(crc32.obj) : error LNK2005: get_crc_table already defined in zlib.lib(zlib1.dll) [C:\node\node.vcxproj]
C:\node\Release\node.exe : fatal error LNK1169: one or more multiply defined symbols found [C:\node\node.vcxproj]