Samples not language aware

[wetndusty]

in many cases changing "Hello, World!" to "Привет, мир!" lead to encoding hell

i guess it not good for newcomers :(

here http2 sample

==========================

const http2 = require('http2');
const fs = require('fs');

const server = http2.createSecureServer({
  key: fs.readFileSync('localhost-privkey.pem'),
  cert: fs.readFileSync('localhost-cert.pem')
});
server.on('error', (err) => console.error(err));

server.on('stream', (stream, headers) => {
  // stream is a Duplex
  stream.respond({
    'content-type': 'text/html',
    ':status': 200
  });
  stream.end('<h1>Hello World (Привет, мир!)</h1>');
});

server.listen(8443);

==================

and how it look in browser -> Hello World (Привет, мир!)

:(

[XhmikosR]

It depends on your editor and its settings. If the file is saved as UTF-8, you shouldn't have such problems.

But I agree, this is too much.

[wetndusty]

my file saved as UTF-8

[XhmikosR]

Wrap your sample code above in code blocks so that it's properly formatted. I cannot try unformatted code.

[wetndusty]

To generate the certificate and key for this example, run:

openssl req -x509 -newkey rsa:2048 -nodes -sha256 -subj '/CN=localhost' \
  -keyout localhost-privkey.pem -out localhost-cert.pem

[XhmikosR]

What happens if you use 'content-type': 'text/html; charset=utf-8'?

[wetndusty]

What happens if you use 'content-type': 'text/html; charset=utf-8'?

not work

[XhmikosR]

Maybe there's something else wrong, then.

Let's wait for others to chime in.

[wetndusty]

i recheck 'content-type': 'text/html; charset=utf-8' work as expected :) typo :) was utf8

so i guess sample at page https://nodejs.org/dist/latest-v12.x/docs/api/http2.html under title "Server-side example" should be changed at line with code
'content-type': 'text/html',
with
'content-type': 'text/html; charset=utf-8',

and sample become international friendly :)

[wetndusty]

google search 'content-type': 'text/html' site:nodejs.org should return zero :)

[wetndusty]

i tried search utf8 at site nodejs.org - it return many - maybe it not ok?

[XhmikosR]

The thing is that the translators shouldn't have translated this in the first place, and secondly this should have been caught up in review.

But anyway mistakes happen so we are here to fix them, including yourself :)

I'm not sure what's the best solution. The easiest one would be to fix this specific snippet, but for the long term we probably need to standardize this.

/CC @Trott

[Trott]

@nodejs/i18n Opinions on how best to address this?

[XhmikosR]

@wetndusty where's this snippet exactly on the website?

[wetndusty]

https://nodejs.org/dist/latest-v12.x/docs/api/http2.html

[XhmikosR]

That's in the core @Trott