Skip to content

tools: update V8 gypfiles for RISC-V - #45149

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
andreas-schwab:main
Oct 26, 2022
Merged

tools: update V8 gypfiles for RISC-V#45149
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
andreas-schwab:main

Conversation

@andreas-schwab

@andreas-schwab andreas-schwab commented Oct 24, 2022 •
edited by targos
Loading

Copy link
Copy Markdown
Contributor

With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

Fixes #45059

@andreas-schwab
tools: update V8 gypfiles for RISC-V
1637a41 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Oct 24, 2022
@richardlau

richardlau commented Oct 24, 2022

Copy link
Copy Markdown
Member

Fixes #45059 ?

@andreas-schwab

andreas-schwab commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

Yes.

@richardlau richardlau added the riscv64 Issues and PRs related to the 64-bit RISC-V architecture. label Oct 24, 2022
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47444/

sxa
sxa approved these changes Oct 24, 2022
View reviewed changes

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :-)

@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 24, 2022
@gengjiawen gengjiawen added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@gengjiawen gengjiawen removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 26, 2022
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot
nodejs-github-bot merged commit e888855 into nodejs:main Oct 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Landed in e888855

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@andreas-schwab @RafaelGSS
tools: update V8 gypfiles for RISC-V
f45dbc8 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@andreas-schwab @RafaelGSS
tools: update V8 gypfiles for RISC-V
a415869 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@andreas-schwab @danielleadams
tools: update V8 gypfiles for RISC-V
1439b34 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@andreas-schwab @danielleadams
tools: update V8 gypfiles for RISC-V
48cf890 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@F3n67u F3n67u mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@sxa sxa sxa approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the 64-bit RISC-V architecture. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

riscv64 (unofficial) builds of v19.0.0 failed

8 participants

@andreas-schwab @nodejs-github-bot @richardlau @targos @gengjiawen @sxa @juanarbol @anonrig