Skip to content

src: move spkac methods to ncrypto - #53985

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jsnell/move-crypto-spkac-to-ncrypto
Closed

src: move spkac methods to ncrypto#53985
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jsnell/move-crypto-spkac-to-ncrypto

Conversation

@jasnell

@jasnell jasnell commented Jul 21, 2024

Copy link
Copy Markdown
Member

No description provided.

@jasnell
jasnell requested review from anonrig and tniessen July 21, 2024 22:59
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnell
jasnell force-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from ea5104c to 9afde2d Compare July 21, 2024 23:06
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 21, 2024
@github-actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2024 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60518/ 💛

@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Jul 21, 2024
@jasnell

jasnell commented Jul 21, 2024

Copy link
Copy Markdown
Member Author

@nodejs/crypto

anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc Outdated
anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc Outdated
@jasnell
jasnell force-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from 9afde2d to 17c1f41 Compare July 22, 2024 14:32
@jasnell
jasnell requested a review from anonrig July 22, 2024 14:35
anonrig
anonrig reviewed Jul 22, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 22, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 22, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2024 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60542/ 💛

@anonrig anonrig added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 25, 2024
jasnell added a commit that referenced this pull request Aug 5, 2024
@jasnell
src: move spkac methods to ncrypto
cf21220 
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell

jasnell commented Aug 5, 2024

Copy link
Copy Markdown
Member Author

Landed in cf21220

@jasnell jasnell closed this Aug 5, 2024
targos pushed a commit that referenced this pull request Aug 14, 2024
@jasnell @targos
src: move spkac methods to ncrypto
e619133 
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
@jasnell @npaun
src: move spkac methods to ncrypto
126fcd7 
PR-URL: nodejs/node#53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@tniessen tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell @nodejs-github-bot @anonrig @targos