Skip to content

deps: patch V8 to 12.8.374.31 - #54682

Closed
targos wants to merge 2 commits into
nodejs:mainfrom
targos:v8-patch
Closed

deps: patch V8 to 12.8.374.31#54682
targos wants to merge 2 commits into
nodejs:mainfrom
targos:v8-patch

Conversation

@targos

@targos targos commented Sep 1, 2024

Copy link
Copy Markdown
Member
  • Revert "deps: remove bogus V8 DCHECK"
  • deps: patch V8 to 12.8.374.31

Refs: v8/v8@12.8.374.22...12.8.374.31

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 1, 2024
@targos targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed build Issues and PRs related to Node.js builds or CI infrastructure. v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Sep 1, 2024
@aduh95 aduh95 added build Issues and PRs related to Node.js builds or CI infrastructure. v8 engine Issues and PRs related to the V8 dependency. author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@jasnell

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member

PR is currently blocked from landing due to unreliable CI

@nodejs-github-bot

This comment was marked as outdated.

@targos targos added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Sep 9, 2024
@targos targos changed the title deps: patch V8 to 12.8.374.26 deps: patch V8 to 12.8.374.31 Sep 9, 2024
@targos

targos commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

Rebased and updated.

@targos targos added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 9, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 123bb4c...9087056

nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2024
This reverts commit fba06eb.

PR-URL: #54682
Refs: v8/v8@12.8.374.22...12.8.374.31
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2024
Refs: v8/v8@12.8.374.22...12.8.374.31
PR-URL: #54682
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
targos deleted the v8-patch branch September 11, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants