[Windows] time: crash on formatting time with de_DE locale

[CharlieClark]

BPO	36792
Nosy	@pfmoore, @vstinner, @tjguk, @jkloth, @zware, @eryksun, @zooba, @Zheaoli
Files	Report.wer Report.wer: Crash report WER9DB9.tmp.WERInternalMetadata.xml: Crash metadate file issue36792.zip issue36792-2.zip

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-03-27.05:48:25.978>
created_at = <Date 2019-05-04.12:33:18.656>
labels = ['interpreter-core', '3.7', 'OS-windows']
title = '[Windows] time: crash on formatting time with de_DE locale'
updated_at = <Date 2021-03-27.05:48:25.977>
user = 'https://bugs.python.org/CharlieClark'

bugs.python.org fields:

activity = <Date 2021-03-27.05:48:25.977>
actor = 'eryksun'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-27.05:48:25.978>
closer = 'eryksun'
components = ['Interpreter Core', 'Windows']
creation = <Date 2019-05-04.12:33:18.656>
creator = 'CharlieClark'
dependencies = []
files = ['48303', '48306', '48307', '48310', '48324']
hgrepos = []
issue_num = 36792
keywords = []
message_count = 40.0
messages = ['341380', '341436', '341437', '341438', '341442', '341444', '341456', '341457', '341462', '341463', '341470', '341473', '341503', '341526', '341529', '341551', '341552', '341561', '341562', '341636', '341669', '341698', '341754', '341755', '341760', '341762', '341773', '341779', '341781', '341784', '341790', '342045', '342232', '342923', '342924', '342966', '361471', '361473', '361871', '389590']
nosy_count = 12.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'jkloth', 'jeremy.kloth', 'zach.ware', 'eryksun', 'steve.dower', 'Manjusaka', 'CharlieClark', 'Dominik Geldmacher', 'Carsten Fuchs']
pr_nums = []
priority = 'normal'
resolution = 'third party'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36792'
versions = ['Python 3.7']

[CharlieClark]

Based on a bug report (https://bitbucket.org/openpyxl/openpyxl/issues/1266/locale) from a user of the openpyxl library I've identified a bug in the zipfile module that causes the Python process to crash on Windows. Currently tested with Python 3.7.3 (32-bit on Windows 10).

Sample code

import faulthandler
import locale
from zipfile import ZipFile

faulthandler.enable()

locale.setlocale(locale.LC_ALL, 'de_DE')
out = open("out.zip", "wb") 
archive = ZipFile(out, "w")
archive.writestr("properties.xml", b"<workbookPr/>")

faulthandler fingers line 1757 as the culprit but running this line locally does not cause the crash. The issue seems to be limited to Windows.

[Zheaoli]

I can't reproduce this error on my system by using the same code.

Could you share the system info with us?

[Zheaoli]

Or would you share the Exception with us ?

I guess it's caused by system setting

[CharlieClark]

Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 21:26:53) [MSC v.1916 32 bit (Intel)] on win32

[Zheaoli]

Same environment.

But I still can not reproduce this exception. I guess maybe it's about the local time or timezone problem. I will find a way to figure it out

[CharlieClark]

That's what we thought when we looked at it, but as I said, I couldn't reproduce it with just the time call or the ZInfo instantiation, so something odd is happening. I do have a German version of Windows as I suspect the original reporter does. You'd think that sort of thing wouldn't matter…

[DominikGeldmacher]

I can reproduce it on Python 3.7.3 german Windows10 enterprise

Windows fatal exception: code 0xc0000374

Current thread 0x00003bc8 (most recent call first):
File "C:\Python37\lib\zipfile.py", line 1757 in writestr

[Zheaoli]

Hi Dominik Geldmacher

May I get your system version? 1809 or 1903?

I guess maybe it's microsoft error

[DominikGeldmacher]

Enterprise 1809 and Professional 1803 (german localized) both reproduce the issue

[Zheaoli]

copy that

I will reset my locale setting to figure it out

[CharlieClark]

winver tells me I have 1809. I'm only using Windows in a VM so I'm not that familiar with its innards.

Also get the error with WinPython 3.6:

Windows fatal exception: code 0xc0000374

Current thread 0x000010c0 (most recent call first):
File "C:\Users\charlieclark\WPy64-3680\python-3.6.8.amd64\lib\zipfile.py", line 1658 in writestr
File "<stdin>", line 1 in <module>

[jkloth]

Related to issue bpo-36319