[easy] undefined name in Lib/idlelib/zzdummy.py

[vstinner]

BPO	40460
Nosy	@terryjreedy, @vstinner
PRs	bpo-40460: Fix typo in idlelib/zzdummy.py #20093

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2020-05-14.22:53:31.346>
created_at = <Date 2020-04-30.23:48:17.516>
labels = ['easy', 'expert-IDLE', '3.9']
title = '[easy] undefined name in Lib/idlelib/zzdummy.py'
updated_at = <Date 2020-05-14.22:53:31.345>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2020-05-14.22:53:31.345>
actor = 'vstinner'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2020-05-14.22:53:31.346>
closer = 'vstinner'
components = ['IDLE']
creation = <Date 2020-04-30.23:48:17.516>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 40460
keywords = ['patch', 'newcomer friendly']
message_count = 4.0
messages = ['367810', '367834', '368871', '368872']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'vstinner']
pr_nums = ['20093']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40460'
versions = ['Python 3.9']

[vstinner]

pyflakes found the following issue:

Lib/idlelib/zzdummy.py:31:33 undefined name 'ztest'

Code:

ztext = idleConf.GetOption('extensions', 'ZzDummy', 'z-text')
(...)
        for line in range(1, text.index('end')):
            text.insert('%d.0', ztest)

Maybe it's a typo: ztext instead of ztest? I'm not sure.

[terryjreedy]

Yes, simple typo. I need to look at test_Zzdummy.py to see if it should have been failing with the typo. If this is executed, the end index must be 1 so that the loop never executes.

[vstinner]

New changeset edf2643 by Victor Stinner in branch 'master':
bpo-40460: Fix typo in idlelib/zzdummy.py (GH-20093)
edf2643

[vstinner]

Yes, simple typo.

Ok, thanks for the confirmation :-) It's now fixed.