Skip to content

First class support for PHP7 and HHVM - #34

Merged
cboden merged 2 commits into
reactphp:masterfrom
clue-labs:php
Feb 24, 2016
Merged

First class support for PHP7 and HHVM#34
cboden merged 2 commits into
reactphp:masterfrom
clue-labs:php

Conversation

@clue

@clue clue commented Nov 21, 2015

Copy link
Copy Markdown
Member

No description provided.

@WyriHaximus

Copy link
Copy Markdown
Member

LGTM :shipit:

@clue

clue commented Nov 21, 2015

Copy link
Copy Markdown
Member Author

Will look into the build error on PHP7…

@WyriHaximus

Copy link
Copy Markdown
Member

That's interesting, haven't seen this happen before to be honest. Take a look at vectorface/dunit, using it in my own projects to test against multiple versions, and could make it easier to test PHP7 locally. (Needs docker though.)

@clue

clue commented Feb 24, 2016

Copy link
Copy Markdown
Member Author

Resolved the build error by removing the affected test (pointless test to begin with).

@cboden cboden added this to the v0.4.2 milestone Feb 24, 2016
cboden added a commit that referenced this pull request Feb 24, 2016
First class support for PHP7 and HHVM
@cboden
cboden merged commit e84048e into reactphp:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants