Skip to content

PHP 7.4 in the test-suite #146

Description

@Nek-

Would be nice isn't it? But I know, I know. It's complicated, because of PHPUnit 8.

But here is something interesting. I tried the following:

diff --git a/composer.json b/composer.json
index f6faa66..fa65403 100644
--- a/composer.json
+++ b/composer.json
@@ -9,8 +9,8 @@
         "evenement/evenement": "^3.0 || ^2.0 || ^1.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^6.4 || ^5.7 || ^4.8.35",
-        "clue/stream-filter": "~1.2"
+        "clue/stream-filter": "~1.2",
+        "symfony/phpunit-bridge": "^5.0"
     },
     "autoload": {
         "psr-4": {

And then that:

$ composer install
$ vendor/bin/simple-phpunit

# Here is the docker version if you prefer
$ docker run --rm -v $(pwd):/app -w /app composer:latest composer install
$ docker run --rm -v $(pwd):/app -w /app php:7.4 vendor/bin/simple-phpunit

And here is the output. Not bad for a code with no modification!

WARNINGS!
Tests: 176, Assertions: 259, Warnings: 14, Skipped: 33.
$ echo $?
0 # no test suite modification no error with PHP 7.4 ✨

I hope it helps. ✌️

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions