You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bebraw I would need bad vs good examples. Also a list which symbols should have a .case alternative. Right now the mathematical and relevant punctuation symbols are fine-tuned to match each other.
@mupastir Can you help with the research for this feature? Examples from other fonts implementing the feature well would be highly useful. Also see Marcus' notes above.
@mupastir@bebraw I am sorry, I still don’t get what the issue is. We have a colon.case and the default asterisk is as big and low as in your examples.
Please provide a list and what you wish to change regarding the current state in terms of design and behaviour.
Sorry, I'm not deep into fonts its definitions, and inner implementations. All I just suggested and as I see it symbols of colon, asterisk, plus, minus would be centered by the height of symbols surrounding them. If there are capitalized symbols around colon, colon should be centered by the height of those symbols. I attached the image to the original PR message.
We discussed this in detail. It seems the behavior of : and * can be improved since those are used in combinations common in programming. It feels like + and - are rare in the combinations visible in examples (usually there's whitespace in between). Based on this, we'll look into improving spacing around : and * as per your suggestion since it feels like there's something to improve.
@mupastir@bebraw@okonet The change from default colon/asterisk to colon.uc/astrerisk.uc (uc = uppercase) is now automated, so that it switches to .uc when the colon is neighboured by two uppercase letters. Please let me know if that would work for you?
Looking good! Can you take a look at - as well since it is commonly used in kebab-cased words kebab-case or KEBAB-CASE
You want the hyphen to move up and down as well? Whats with mixed cases like Middle-Class? I am still reluctant since variants likes these also alsways create inconsistencies.
Activity
bebraw commentedon Feb 28, 2025
We discussed this issue and we would need a few examples to consider what it might look like. Here's a couple I generated using ChatGPT:
MarcusSterz commentedon Mar 5, 2025
@bebraw I would need bad vs good examples. Also a list which symbols should have a
.casealternative. Right now the mathematical and relevant punctuation symbols are fine-tuned to match each other.bebraw commentedon Mar 5, 2025
@mupastir Can you help with the research for this feature? Examples from other fonts implementing the feature well would be highly useful. Also see Marcus' notes above.
mupastir commentedon Mar 5, 2025
@bebraw Yeah, sure! I'll prepare some examples and post them there.
mupastir commentedon Mar 5, 2025
@bebraw @MarcusSterz
What I proposed in this PR is actually what I saw in FiraCode, that's why I show only the examples I see from this font.
As I see it, context awareness is applied to capital letters only if they stand close without any space symbols.
But for * symbol it works another way. It sticks to the baseline when it stands before any other symbol.
Let me know if I provided not relevant or not enough info.
MarcusSterz commentedon Mar 5, 2025
@mupastir @bebraw I am sorry, I still don’t get what the issue is. We have a
colon.caseand the defaultasteriskis as big and low as in your examples.Please provide a list and what you wish to change regarding the current state in terms of design and behaviour.
mupastir commentedon Mar 10, 2025
Sorry, I'm not deep into fonts its definitions, and inner implementations. All I just suggested and as I see it symbols of colon, asterisk, plus, minus would be centered by the height of symbols surrounding them. If there are capitalized symbols around colon, colon should be centered by the height of those symbols. I attached the image to the original PR message.
mupastir commentedon Mar 10, 2025
If this suggestion does not align with the project’s goals, feel free to close the PR. I appreciate your time and consideration!
okonet commentedon Mar 10, 2025
@mupastir thanks for bringing this up. We will discuss this internally and get back to you. I think we have enough information now. Thanks!
bebraw commentedon Mar 14, 2025
We discussed this in detail. It seems the behavior of
:and*can be improved since those are used in combinations common in programming. It feels like+and-are rare in the combinations visible in examples (usually there's whitespace in between). Based on this, we'll look into improving spacing around:and*as per your suggestion since it feels like there's something to improve.bebraw commentedon Mar 14, 2025
I actually found a counterpoint for
-: kebab case (CC @MarcusSterz). That's used commonly in CSS.MarcusSterz commentedon Apr 25, 2025
@mupastir @bebraw @okonet The change from default colon/asterisk to colon.uc/astrerisk.uc (uc = uppercase) is now automated, so that it switches to .uc when the colon is neighboured by two uppercase letters. Please let me know if that would work for you?
okonet commentedon Apr 28, 2025
Looking good! Can you take a look at
-as well since it is commonly used in kebab-cased wordskebab-caseorKEBAB-CASEMarcusSterz commentedon Apr 28, 2025
You want the hyphen to move up and down as well? Whats with mixed cases like
Middle-Class? I am still reluctant since variants likes these also alsways create inconsistencies.okonet commentedon Apr 28, 2025
Yeah let's leave it for now.