Repository navigation
Remove unneeded URL validation - #1011
Conversation
… duplicating some functionality. Remove some IPv6 checks that were never actually run
…sed URL validation checks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1011 +/- ##
=============================================
- Coverage 81.50% 81.47% -0.04%
+ Complexity 2923 2907 -16
=============================================
Files 122 122
Lines 11653 11638 -15
=============================================
- Hits 9498 9482 -16
- Misses 2155 2156 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…in can be installed
|
Note there's currently an issue in |
PS: @dkotter this how @galatanovidiu is handling it in |
What?
Remove some URL validation code that is no longer needed as we can rely on changes introduced in WP 7.0.3
Why?
We recently updated the validation we run on URLs when someone passes an image URL into our Alt Text Generation Ability. Some of the validation introduced there is no longer needed as WordPress added the same changes in v7.0.3 so this PR simplifies things a bit to rely on Core as much as possible.
How?
wp_http_validate_urland remove code that we no longer needUse of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Evaluating our current code against WordPress Core to determine what could be cleaned up. All changes tested and reviewed by me
Testing Instructions
Ensure the Alt Text Generation feature still works as expected.
If desired, directly invoke the Alt Text Generation Ability with a custom
image_urlpassed in to ensure that worksChangelog Entry