Repository navigation
Add accessible name to header navigation blocks - #104
Merged
carolinan merged 5 commits intoSep 28, 2026
Merged
Conversation
shail-mehta
marked this pull request as ready for review
September 24, 2026 15:16
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #100.
Adds a translatable
ariaLabelofPrimaryto the Navigation block in the header patterns (header-default,header-stick,header-collapsed).Without an
ariaLabel, the block falls back toaria-label="Navigation". Accessibility-ready landmark guidance asks for a name that does not include the landmark type (e.g.Primary, notPrimary navigation).Screenshots
N/A - change is an
aria-labelon the header<nav>.Testing Instructions
<nav>- it should havearia-label="Primary"(notNavigation).aria-labelon each.Use of AI Tools
Cursor (For PR Description)