Repository navigation
Introduce .gitattributes in favor of .distignore #217
Copy link
Copy link
Closed
Labels
Good First IssueIssue particularly suitable to be worked on by new contributorsIssue particularly suitable to be worked on by new contributorsInfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure
Milestone
Description
Activity
added on Mar 7, 2022
InfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure
Needs DevAnything that requires development (e.g. a pull request)Anything that requires development (e.g. a pull request)
Good First IssueIssue particularly suitable to be worked on by new contributorsIssue particularly suitable to be worked on by new contributors
Will also want to make sure that README.md gets added to either file as that's currently being published to WP.org (alongside the more useful readme.txt file), see: https://plugins.trac.wordpress.org/browser/performance-lab/trunk/README.md
Reacted by Crisoforo Gaspar Hernández and Felix Arntz
added on Mar 8, 2022
Needs DiscussionAnything that needs a discussion/agreementAnything that needs a discussion/agreement
and removed Needs DevAnything that requires development (e.g. a pull request)Anything that requires development (e.g. a pull request)
Why should we be using .gitattributes over .distignore? I'm not sure I see the benefits of that.
ZIPs created from a release tag contains non required files:
Benefits
- When using
gitattributesthose files won't be included on the created file instead. - Zip from the release tag would match closely the ZIP from WP.org instead
gitattributesworks for the WP release action so we get both benefits in both areas.
Reacted by Felix Arntz and Jeffrey Paul
@mitogh Good point, that makes sense to me.
So as a summary what needs to be done here:
- Migrate the current
.distignoreto a.gitattributesfile (usingexport-ignore, see Introduce.gitattributesin favor of.distignore#217 (comment)). - Include
README.mdin that file so that it is excluded from ZIP files as well.
Reacted by Crisoforo Gaspar Hernández and Jeffrey Paul
added on Mar 8, 2022
Needs DevAnything that requires development (e.g. a pull request)Anything that requires development (e.g. a pull request)
and removed Needs DiscussionAnything that needs a discussion/agreementAnything that needs a discussion/agreement
added and removed on Mar 9, 2022
Needs DevAnything that requires development (e.g. a pull request)Anything that requires development (e.g. a pull request)
Metadata
Metadata
Assignees
Labels
Good First IssueIssue particularly suitable to be worked on by new contributorsIssue particularly suitable to be worked on by new contributorsInfrastructureIssues for the overall performance plugin infrastructureIssues for the overall performance plugin infrastructure
Feature Description
The current release zips created by GH everytime a new tag is created includes files that are not part of the release, for example:
Contains tests and configuration files, non required for testing or usage of the plugin.
The deploy action would use either:
.disignore.gitattributesTo exclude files that are going to be deployed so we can safely move
.disignoreto.gitattributesone of the things to consider is when moving the content into.gitattributesis the fact that the settingexport-ignoreshould be added after each file for example:export-ignoreAdditional parameters.