Skip to content

Enqueue scripts using plugins_url() instead of plugin_dir_url() - #1761

Merged
mukeshpanchal27 merged 2 commits into
WordPress:trunkfrom
SohamPatel46:update/enqueue-scripts-to-use-plugins-url
Dec 20, 2024
Merged

mukeshpanchal27 merged 2 commits into
WordPress:trunkfrom
SohamPatel46:update/enqueue-scripts-to-use-plugins-url

Conversation

@SohamPatel46

Copy link
Copy Markdown
Contributor

Summary

Fixes #1647

Relevant technical choices

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SohamPatel46 <sohampate1@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SohamPatel46

Copy link
Copy Markdown
Contributor Author

Hello, Can someone with access can add the required labels ? I dont seem to have enough access to do that.

@swissspidy swissspidy added this to the performance-lab n.e.x.t milestone Dec 19, 2024
@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective [slug: optimization-detective] [Plugin] Embed Optimizer [slug: embed-optimizer] [Plugin] Image Prioritizer Dependent on Optimization Detective (optimization-detective) [slug: image-prioritizer] [Plugin] Web Worker Offloading [slug: web-worker-offloading] [Plugin] Performance Lab [slug: performance-lab] labels Dec 19, 2024

@westonruter westonruter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukeshpanchal27
mukeshpanchal27 merged commit ebec285 into WordPress:trunk Dec 20, 2024
@westonruter westonruter changed the title Enqueued scripts should use plugins_url() instead of plugin_dir_url() Enqueue scripts using plugins_url() instead of plugin_dir_url() Jan 25, 2025
@westonruter westonruter mentioned this pull request Jan 25, 2025
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Embed Optimizer [slug: embed-optimizer] [Plugin] Image Prioritizer Dependent on Optimization Detective (optimization-detective) [slug: image-prioritizer] [Plugin] Optimization Detective [slug: optimization-detective] [Plugin] Performance Lab [slug: performance-lab] [Plugin] Web Worker Offloading [slug: web-worker-offloading] [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enqueued scripts should use plugins_url() instead of plugin_dir_url()

4 participants